Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to tauri alpha.16, api alpha.9 #673

Merged
merged 14 commits into from
Oct 20, 2023
Merged

chore: update to tauri alpha.16, api alpha.9 #673

merged 14 commits into from
Oct 20, 2023

Conversation

lucasfernog
Copy link
Member

No description provided.

@lucasfernog lucasfernog requested a review from a team as a code owner October 19, 2023 23:36
@socket-security
Copy link

socket-security bot commented Oct 19, 2023

Comment on lines 18 to 20
return await window.__TAURI_INTERNALS__.invoke(
"plugin:authenticator|init_auth",
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't really on window.__TAURI_INTERNALS__ anymore, it is internal and should be treated as such in this repo, we should use invokedirectly from @tauri-apps/api/primitives which provides the abstraction around the internals.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do this for the plugins because otherwise each plugin global JS script would consume an extra 1.5-2KB on the binary :(

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I'm not seeing a huge change anymore... weird

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe your cleanup is saving us :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pushed, but on the notification init.js script I can't really do anything about it :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could turn that script into a ts file that we compile with rollup

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the things we do for love

FabianLars
FabianLars previously approved these changes Oct 20, 2023
@lucasfernog lucasfernog merged commit 5c13736 into v2 Oct 20, 2023
171 of 179 checks passed
@lucasfernog lucasfernog deleted the feat/alpha.16 branch October 20, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants